Gang Wu comments

Results 304 comments of


                                            Gang Wu

PARQUET-2474: Add FIXED_SIZE_LIST logical type

cc @JFinis

MINOR: Fix docstring style

I wonder if there is any good linter for thrift

Add support for protobuf version 4.29.x

@Fokko Is it safe to bump the major version of protobuf?

[GH-3035] [WIP] ParquetRewriter: Add a column renaming feature

Thanks for the explanation! I asked for `column ordering` because renaming and reordering may happen together in the case of schema evolution. We can support them in the future when...

[GH-3035] [WIP] ParquetRewriter: Add a column renaming feature

Yes, I think this is a fair use case, provided that the code logic does not change a lot.

GH-40868: [C++][Parquet] Minor: Remove "Experimental" for parquet::RecordReader

I would prefer fixing those compile errors at the same time. We have to do that any way.

GH-40868: [C++][Parquet] Minor: Remove "Experimental" for parquet::RecordReader

IMHO, it is literally weird to remove `experimental` before removing `internal` namespace. The expectation is that the API is stable after removing `experimental` except that we will include the namespace...

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

I will take a look this weekend. Thanks for reviving this!

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

Sorry for missing this! I will take a look. Meanwhile, I don't think we need to hurry for the code freeze.

GH-34785: [C++][Parquet] Parquet Bloom Filter Writer Implementation

Could you please fix the CI failure?