Weihang Lo

Results 766 comments of Weihang Lo

Thanks for the pull request. Just note that in Cargo a feature discussion usually happens in an issue. We leave pull requests for implementation specific discussions. See https://doc.crates.io/contrib/process/working-on-cargo.html#before-hacking-on-cargo

Thanks for the clarification! Yeah I realised that immediately after posting that comment 😬 The discussion is now happening here https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Simulate.20Edition.202024.20lints.20in.20edition.20migration

Thanks for working with us! Glad to have you along! I am going to merge this. This feature is not controversial at all, so no need to wait for the...

Thank you for the suggestion. I learnt new stuff today! As I understand it, with [sparse-checkout], git still needs to clone the whole repository index. Only if pairing with [partial-clone]...

The idea is that Cargo avoids depending on external binaries. We can't control how external binaries evolve. It might become a compatibility issue. That's why [`net.git-fetch-with-cli`](https://doc.rust-lang.org/nightly/cargo/reference/config.html#netgit-fetch-with-cli) is not the default....

@bors try Let's see how it really goes.

All tests are passed. I will do another round of review today.

It has been listed in changelog of 1.83 already, under the nightly section! https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-183-2024-11-28 Though we haven't figured out the build script part (see ), maybe we could celebrate a...