Weihang Lo

Results 766 comments of Weihang Lo

`git-lfs` is a tool built upon Git's [filter](https://git-scm.com/docs/gitattributes#_filter) attributes. [This paragraph](https://github.com/git-lfs/git-lfs/blob/main/docs/spec.md#intercepting-git) describes how it works. Not sure what you actually mean by supporting git-lfs. Guess you mean implementing [the Git...

No date ATM. This is a libgit2 Rust binding, so we get whatever upstream libgit2 provides

Sounds like a good attempt as well as a preparation of the sha256 stabilization. We just need to make sure that it is documented as experimental and has tests covered

Just saw ehuss has left comments and noticed the public dependency issue I wasn't aware of. I totally agree with that being a way bigger problem than other issues I've...

Should we wait for #14049, or this can be reviewed independently?

I don't object to adding a file. Have seen contributors tweaking unrelated formatting in pull requests, I should have realized it might be a global `rustfmt.toml` doing that. It makes...

Probably relevant: * https://github.com/rust-lang/rust/issues/118372 * https://github.com/rust-lang/rfcs/pull/2794

I feel like Cargo should not reinvent `--env-set` in inself, and should probably just wait for the stabilization of the feature.

While `--env-set` is an approach to fulfill this feature, it might be considered as a breaking change to recursive `cargo` calls, like what has been described in #14194. This kind...

Thanks for the report. I am not sure if rustc starts using `-Ztrim-paths` to sanitize backtrace. Could you pick a toolchain version prior to `-Ztrim-paths` and try if it can...