cargo icon indicating copy to clipboard operation
cargo copied to clipboard

fix(resolve): Dont show locking workspace members

Open epage opened this issue 1 year ago • 2 comments

What does this PR try to resolve?

This is for cargo generate-lockfile and when syncing the lockfile with the manifest. We still show it for cargo update because of cargo update --workspace.

We hacked around this previously by filtering out the num_pkgs==1 case for single packages but this didn't help with workspaces.

How should we test and review this PR?

Additional information

This builds on #14440

epage avatar Aug 22 '24 22:08 epage

r? @weihanglo

rustbot has assigned @weihanglo. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Aug 22 '24 22:08 rustbot

This PR had a refactor on it, merging the cargo generate-lockfile and the lockfile sync (e.g. cargo check) reporting but I realized there was a difference that we might want to preserve: cargo generate-lockfile only shows Adds with relevant information to avoid overwhelming the user.

epage avatar Aug 23 '24 02:08 epage

@bors r+

Thanks!

weihanglo avatar Aug 26 '24 22:08 weihanglo

:pushpin: Commit d2ec764995885a74f607669c74cbda60787a924e has been approved by weihanglo

It is now in the queue for this repository.

bors avatar Aug 26 '24 22:08 bors

:hourglass: Testing commit d2ec764995885a74f607669c74cbda60787a924e with merge ef854d2f66df7bfcd803a6ca1cfa3b619603142c...

bors avatar Aug 26 '24 22:08 bors

:sunny: Test successful - checks-actions Approved by: weihanglo Pushing ef854d2f66df7bfcd803a6ca1cfa3b619603142c to master...

bors avatar Aug 26 '24 22:08 bors