Wouter Deconinck

@spackbot fix style

This is the `spack spec` for the same install, including what's available on binaries. ``` # spack spec hpctoolkit@develop Input spec -------------------------------- - hpctoolkit@develop Concretized -------------------------------- - hpctoolkit@develop%[email protected]~cuda~level_zero~mpi~opencl+papi~python~rocm~strip+viewer build_system=meson buildtype=release...

> If we could somehow tweak it to have more legible nodes it would be nice We can define node styles, but increasing font size doesn't quite do what you'd...

Do we want to remove these from https://github.com/alalazo/spack/blob/deprecation/container-images/lib/spack/spack/container/images.json as well? If we are not testing builds, are we still willing to guarantee that containerize works?

I guess the failure scenario I'm imagining is someone running `spack containerize --list-os`, seeing `fedora:38` (since parsed from images.json), and using that to start their container build from. `FROM spack/fedore38...

@tmadlener Can you comment on whether you identified if this missing `` header became apparent due to any specific change between 38.0 and 38.1, or if it was related to...

Thanks for the feedback. I've enabled the patch for all versions, since this is a missing header bug in all versions since 29 (at least). It was just surfaced by...

Then this just need a review by either @vvolkl or @drbenmorgan, as maintainers.

Seems caused by https://github.com/spack/spack/blob/b79761b7eb5eb2e2d6b8174c3043524462772bf6/share/spack/setup-env.sh#L165 Instead of just passing the subcommand to `spack env` it should inject the `-d` option again.

Would you be interested in contributing this change as a pull request? We would very much welcome this contribution, and it does not imply any future maintenance promise from you...