Thomas Watson

Results 145 comments of Thomas Watson
trafficstars

* **#4520** 👈 * **#4521** : 1 other dependent PR ([#4492](https://github.com/DataDog/dd-trace-js/pull/4492) ) * **#4515** * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join...

* **#4757** * **#4549** 👈 * **#4728** * **#4727** : 1 other dependent PR ([#4729](https://github.com/DataDog/dd-trace-js/pull/4729) ) * `master` This stack of pull requests is managed by Graphite. Learn more about...

* **#5156** 👈 (View in Graphite) * `master` This stack of pull requests is managed by Graphite. Learn more about stacking.

> We could improve the code a tad by reusing the start time as timeout later. Do you mean `timestamp` instead of `timeout`?

> We could improve the code a tad by reusing the start time as timestamp later. That sounds good. I'll do that in a separate PR as it's not really...

@BridgeAR Oh hang on... hrtime has no basis in real time as it has an arbitrary start time, so it can't be used for timestamps.

* **#5764** 👈 (View in Graphite) * `master` This stack of pull requests is managed by Graphite. Learn more about stacking.

* **#5961** * **#4744** 👈 (View in Graphite) * `master` This stack of pull requests is managed by Graphite. Learn more about stacking.

It also had a lot of failing tests. I can't remember the issues at the moment, but I'll try to re-run them so we can see

Ah, yes... I start to remember some of the issues: The new version of tap changes how code coverage is generated, so the way we configure that needs to be...