Thomas Watson

Results 127 comments of Thomas Watson
trafficstars

I see your point, but let's just keep it pragmatic. There's a header of 350 pixels above the first result and each result is 44 pixels. So how about just...

LGTM 😃 - Any input @vanjacosic?

* **#5320** 👈 (View in Graphite) * **#5216** : 4 other dependent PRs ([#5218](https://github.com/DataDog/dd-trace-js/pull/5218) , [#5274](https://github.com/DataDog/dd-trace-js/pull/5274) , [#5334](https://github.com/DataDog/dd-trace-js/pull/5334) and 1 other) * **#6027** * **#6026** * `master` This stack of...

@simon-id Please read the PR description ;) All your questions are already addressed there, but the TLDR is: > Are we sure the memwatch thingy should be excluded ? Pretty...

I added a commit which includes all files automatically added by npm, which technically doesn't have to be included in the `files` list. But based on review feedback it has...

* **#4796** 👈 * `master` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @watson and the rest of your teammates on Graphite

Closing in favor of https://github.com/DataDog/dd-trace-js/pull/4816

* **#5864** 👈 (View in Graphite) * **#5863** * **#5861** * `master` This stack of pull requests is managed by Graphite. Learn more about stacking.

> Any way to do this without creating such a variable? I haven't been able to think of anything, as it has to be configurable from outside the sandbox 🤷...

Haha, yeah I knew this change was going to be controversial - and to be honest I don't really like it myself either. But I'm really happy for the discussion....