Sergei Golubchik

Results 124 comments of Sergei Golubchik

@DaveGosselin-MariaDB my point was that this particular test, and, I suspect many mac-specific failures could be covered by `include/have_case_insensitive_fs.inc`. That is, the question was what tests fail not just *on...

Looks rather risky to me. The server was ignoring capability flags from the after-ssl client packet for >20 years. It is totally possible that some third-party clients don't even send...

> @vuvova wrote: > > > Looks rather risky to me. The server was ignoring capability flags from the after-ssl client packet for >20 years. It is totally possible that...

To clarify the comment > The big problem with the TLS port is the need to add a new option flag for all client programs and any connector that implements...

Could you elaborate on why the stack size calculation is inaccurate? In particular, why `thd->thread_stack` is wrong?

> We could call MY_INIT, however some memory is leaked on test program exit in that case did you pair it with `my_end()` at the end?

why couldn't you simply set `innodb_flush_log_at_trx_commit=0` ? That would be as fast or may be even faster, wouldn't it?

I'm uncomfortable with the idea of disabling durability by default. Surely it's not what users expect. For testing purposes you can use `--debug-no-sync` like mtr does. `my_sync()` could use `F_BARRIERFSYNC`...

Yes, I know. Making all tests pass is still work in progress