Sergei Golubchik

Looks good, but please add a test for a syntax error, like ```sql CREATE OR REPLACE TRIGGER IF NOT EXISTS ev1 IN SCHEDULE EVERY 1 SECOND DO DROP DATABASE db1;...

Note, this won't be pushed into 11.6 right now, it would just be seen as a strange and redundant alias of an existing feature. We'll push everything together, then it'll...

I think it'll be the same object, so no need to differentiate. `EVENT` is very overloaded concept, e.g. very often people speak of "binlog events", which are completely different. What...

I don't understand that at all. First, why "noerror" argument, when one can simply write ```cmake SET(MY_WARNING_FLAGS_NON_FATAL -Wno-error=reorder -Wno-error=effc++ ) ``` or even ```cmake FOREACH(F ${MY_WARNING_FLAGS_NON_FATAL}) MY_CHECK_AND_SET_COMPILER_FLAG(-Wno-error=${F} DEBUG RELWITHDEBINFO) ENDFOREACH()...

we don't really want to push more of the server logic inside InnoDB. Besides triggers cascading updates/deletes have problems with `CHECK` constraints, unique constraints `WITHOUT OVERLAP` and `USING HASH`, online...

I don't quite understand, what does it test?

you mean, you test that an invalid certificate isn't accepted? I'm sure there are existing tests for that

This is already tested, in the very same file, few lines below: https://github.com/MariaDB/server/blob/bfcd2674a3b20b105393970d3937cdc18f43ce23/mysql-test/main/openssl_1.test#L67-L76

I believed the server will reject an invalid certificate before it'll start looking at the subject, so it doesn't matter how similar the subject is. Are you saying this is...

sorry, I've missed it when it was created. Why safemalloc backtrace functionality doesn't work on Mac OS X?