server icon indicating copy to clipboard operation
server copied to clipboard

MDEV-33616 Tests failing on macOS

Open DaveGosselin-MariaDB opened this issue 1 year ago • 3 comments

MDEV-33616 Tests failing on macOS

These tests rely on THR_KEY_mysys but it is not initialized.  On
Linux, the corresponding thread variable is null, but on macOS it has a
nonzero value.  In all cases, initialize the variable explicitly by
calling MY_INIT and my_end appropriately.

DaveGosselin-MariaDB avatar Apr 15 '24 15:04 DaveGosselin-MariaDB

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 15 '24 15:04 CLAassistant

We could call MY_INIT, however some memory is leaked on test program exit in that case

did you pair it with my_end() at the end?

vuvova avatar Apr 15 '24 18:04 vuvova

We could call MY_INIT, however some memory is leaked on test program exit in that case

did you pair it with my_end() at the end?

I saw the MY_INIT macro standing alone and didn't know about my_end(). I tried that and it works, so I'll deliver that instead of the factoring-based approach.

DaveGosselin-MariaDB avatar Apr 15 '24 19:04 DaveGosselin-MariaDB