Viktor Szakats

> The documentation for `BCRYPT_KDF_RAW_SECRET` also indicates that it should work on 2012R2/8.1: > > > Windows 8, Windows Server 2008, Windows Vista, Windows Server 2003 and Windows XP: This...

For tests the `LIBSSH2_ERROR_UNSUPPORTED_PLATFORM` = 'inconclusive' path is looking good. Thinking of downstream code trying to use libssh2 though, I'm not sure this would be workable without breaking those when...

> I'm sure we could do a Windows version check somehow, but I worry that it would be a high-impact change: All places that currently use `#if LIBSSH2_ECDSA` (of which...

Thanks @jpassing for the great work. Merged now.

@jay: `#ifdef CURL_STATICLIB` probably doesn't work for this because we have it enabled for both static and shared builds now. With CMake the approach we use with `libcurl.rc` might work...

IMO `CURL_STATICLIB` itself is a hack, and I think it shouldn't be there in the first place when compiling the lib itself. If we depend on this for anything that...

Here's a rough patch building seemingly fine with CMake (while also keeping autotools working, but not tested). Except this: ``` lib/dllmain.c:41:13: warning: no previous prototype for 'DllMain' [-Wmissing-prototypes] 41 |...

> It's great that it's possible to do a single pass with CMake for both shared and static but we have to account for other build systems. Also we tell...

> `CURL_STATICLIB` is about libcurl being static, not OpenSSL. What if you build libcurl dynamically with a static OpenSSL? Official `libcurl.dll` is doing that, might be useful to cover. (Can't...

Here's one take reusing `CURL_STATICLIB`. Works with the happy-path, buts need (much) more testing before merging: Notably it drops `CURL_STATICLIB` from _all_ shared compiles when using `SHARE_LIB_OBJECT=OFF`, which may or...