Viktor Szakats

Results 206 comments of Viktor Szakats

We believe this is fixed in current master. Please reopen, if still relevant.

Needs this for merge: ```diff --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -10,6 +10,7 @@ dist_man_MANS = \ libssh2_agent_init.3 \ libssh2_agent_list_identities.3 \ libssh2_agent_set_identity_path.3 \ + libssh2_agent_sign.3 \ libssh2_agent_userauth.3 \ libssh2_banner_set.3 \ libssh2_base64_decode.3...

Turns we have a PR for `libssh2_agent_sign()` with a different implementation: #752 Which one is the preferred implementation?

Closing in favour of #752. Thanks @cerevra. Ref: https://github.com/libssh2/libssh2/pull/752#issuecomment-1517958323

> I still have CI errors and this time not just for Windows builds. It is almost always in the first test: https://github.com/libssh2/libssh2/actions/runs/4365242982/jobs/7638036383#step:7:1561 These intermittent failures appeared a few weeks...

Something went off with GitHub Actions / Jobs yesterday. Status page was/is all green all along. Oh, they added a new entry today: https://www.githubstatus.com/incidents/ybnn77s3lyf8

Proposing this patch to fix the nits and bump length to `size_t`: ```diff diff --git a/docs/Makefile.am b/docs/Makefile.am index 235e77c5..9ddadc93 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -50,6 +50,7 @@ dist_man_MANS =...

This would be a superb addition.

This has landed in 3c953c05d67eb1ebcfd3316f279f12c4b1d600b4.

Yosemite's default `OpenSSH_6.2p2, OSSLShim 0.9.8r 8 Dec 2011` works with this line: `Ciphers aes256-ctr,aes192-ctr,aes128-ctr` Yosemite with Homebrew `OpenSSH_6.7p1, OpenSSL 1.0.1l 15 Jan 2015` supports the full list: `Ciphers [email protected],[email protected],aes256-ctr,aes192-ctr,aes128-ctr`