Viktor Szakats

Results 206 comments of Viktor Szakats

Closing due to no response and a missing option to edit the patch. You're welcome to reopen on a fresh master.

Re-applying this fix to master: https://github.com/libssh2/libssh2/pull/816

After making an updated version of this PR locally, the build fails in an odd way (on macOS), see below. Also there have been a bunch of improvements with existing...

@vtorri: speaking of speed, CMake should be faster now on Windows, due the efforts made to eliminate as much detection steps as possible. We also still have `Makefile.mk` (formerly known...

CMake provides MSVC support (autotools doesn't), which seems to justify supporting it next to autotools. After recent updates, both should work equally well for most cases and have fairly good...

Thanks for the input to everyone. The conclusion is that we are not planning to add a new build system. Having said that it was interesing to hear about Meson,...

In my experience for projects of sizes comparable to libssh2 (= smaller ones), CMake and autotools are slow on Windows because of their often inflated detection phase. On Windows, file...

No, I meant to use this with CMake (though on a second thought, I'm not sure it's a good idea, as it would introduce surprising/unexpected behaviour): https://github.com/libssh2/libssh2/blob/272a17ce266b4428c95c5337925aababc4acfa53/src/libssh2_setup.h#L22-L44 With the patch...

Closing this in favour of: #790

@jnqnfe We're happy to accept a documentation patch for this.