Vlad Neverov
Vlad Neverov
I agree that this might be handy. Although, in particular case of PR #246 the contents of the lists do not change after initialisation, and I like the use of...
I think the only way to do it is by using a lookup table: ```python pec93_adf04 = { 'pec93#he_pju#he0.dat': 'helike/helike_kvil93he.dat', 'pec93#he_llu#he0.dat': 'helike/helike_kvil93he.dat', 'pec93#be_pju#be0.dat': 'belike/belike_wjd91#be.dat', 'pec93#be_llu#be0.dat': 'belike/belike_wjd91#be.dat', 'pec93#be_pju#be1.dat': 'lilike/lilike_wjd91be.dat', 'pec93#b_llu#b0.dat': 'copmm#5/ls#b0.dat',...
I would prefer `cherab.generomak` over `cherab.tools.generomak`. I think it is important that the internal structure of `cherab.generomak` can be used as an example for creating Cherab modules for real machines.
I propose the following API change to fix this: 1. `Line(element, charge, transition)` -> `Line(element, charge, identifier)`. Argument `identifier` can be a transition tuple or an ADAS wavelength key. The...
>This is a very unfortunate bug and the API changes suggested are quite significant. I suggest we discuss this at the next Technical Management Committee meeting to choose a course...
> If we are being particularly helpful, we could add a "patch" system that addresses known issues with the source data in a consistent way, e.g. relabelling data where there...
When the Raysect binaries for NumPy 2.0 become available, we'll need to make the following changes: **pyproject.toml**: ``` [build-system] requires = [ "setuptools>=62.3", "oldest-supported-numpy; python_version < '3.9'", "numpy~=2.0; python_version >=...
> Yeah, agree it should default to local coordinates for backwards compaitibility. But the mesh already has a transform applied to it (effectively its own Node), we just need a...
While Raysect doesn't allow you to set a non-constant spectral resolution (this would affect dispersion rendering and other features), Cherab does have a tool that can do some pre- and...
Hello, @khowarthCFS Raysect 0.7.1 does not include `pyproject.toml`. The file was added later in version 0.8.1. So `pip` uses the legacy `setup.py install` method, but `setup.py` itself requires `numpy` and...