Vlad Neverov

Results 70 comments of Vlad Neverov

Thanks a lot for the review, @Mateasek. I agree with all your suggestions. They are implemented in the latest commits.

I've added support for the `CHERAB_ATOMIC_DATA` environment variable from #416. The [PR #5](https://github.com/cherab/adas/pull/5) in `cherab-adas` demonstrates how much simpler the subpackage will become after this PR is accepted. Since #400...

Obviously, this change is too big to make in one PR. I'll break it down into several PRs. The first will affect only the documentation, improving docstrings of the `openadas.repository`...

My colleagues recently performed calculations similar to those in O. Marchuk's [paper](http://dx.doi.org/10.1088/0953-4075/43/1/011002) and obtained the dependences of the Balmer-alpha MSE spectrum component ratios on the beam energy, electron density and...

Hi @Mateasek, Thank you very much for this draft PR. I agree that this is a major step in the right direction. I looked at the output of the FEDASIM...

For the plasma composition, I think we could restrict ourselves to level resolution for hydrogen and H-like ions, and metastable resolution for other species. This would allow to use metastable-resolved...

I was thinking about how to add this new beam architecture in 1.5 without breaking user code and I came up with a possible solution. I think, we should keep...

Hi @Mateasek, >at the end, we will add the new architecture along the old one. The new one will be sitting in particle_beams. I agree it's better, considering that there...

> Looks good. Test coverage, documentation and demo provision is good for the new additions. Since the beam line shape classes have also been moved, could you add some tests...

I am currently adding Zeeman spectral line shapes to Cherab along with unit tests. The `TestLineShapes` class will also include the tests for `GaussianLine`, `MultipletLineShape` and `StarkBroadenedLine`, because all these...