Vlad Neverov

Results 70 comments of Vlad Neverov

Hi, Yes, this applies to all binary arithmetic methods. As pointed out by @jacklovell in #373, there is a directive `c_api_binop_methods=True` that allows the old implementation to continue working. I...

> I am also trying to fix all binary arithmetic methods at least and going to push the PR, so please consider it if you are welcome. Thank you very...

> It would at least solve this specific case of defining the size of statically-sized arrays, as well as a bunch of other integer definitions in the code. The DEF...

The `set_window_title` [is no longer available](https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.6.0.html#classes-methods-and-attributes) as a canvas method in Matplotlib 3.6 and pipelines now throw an error. I think a hotfix is needed. @CnlPepper, if you are happy...

> Wouldn't this mean these observers would silently ignore any options they don't support? If `**kwargs` parameters are only added to inherited classes, the base class constructor will throw an...

All non-imaging observers accept arguments of the base observer classes explicitly, for example `FibreOptic`: https://github.com/raysect/source/blob/66fdf70933f5f48c049917c0667be874edc9def7/raysect/optical/observer/nonimaging/fibreoptic.pyx#L75-L87 Both imagine and non-imaging observers should accept base class arguments in the same way. There...

> There are currently only six imaging observers in Raysect, I don't see a problem adding base class arguments to their initialisers explicitly. Indeed, it's more descriptive because it reduces...

> Have you checked that this normalisation scheme gives identical results (at least to within numerical precision) as the original function, for Scipy < 1.12.0? Intuitively I feel like it...

Hi @Mateasek, I think the way you defined the headers in #297 is fine. There are not so many PEC versions in ADAS. It is likely that the same problem...

I've added tests, demos and documentation, so I think this PR is ready for review.