core icon indicating copy to clipboard operation
core copied to clipboard

Full Generomak plasma

Open mattngc opened this issue 5 years ago • 4 comments

The TMC has an ambition for Cherab to have a full range of tutorials and model demonstrations that can be run on a simple python environment without complex dependencies. The simplest way to achieve this would be to have a full plasma and Tokamak description that is self contained inside the repository. We already have an example equilibrium and bolometry observers.

Through this issue we propose the concept of Generomak. A generic hypothetical Tokamak which is completely self described within the Cherab package. All required input data for the plasma, wall description and diagnostics is available in a simple abstracted form.

As an initial configuration set we propose:

  • equilibrium (already available)
  • core plasma
  • edge plasma
  • NBI beam
  • first wall (Octant with simple low poly tiles and a few port holes)

A basic diagnostic set could include:

  • bolometry (already existing)
  • IRVB (in progress, #206 )
  • core spectroscopy (beam and passive)
  • divertor spectroscopy

Please use this thread to propose components. The individual components will be raised and tracked in separate issues.

mattngc avatar Jan 31 '20 15:01 mattngc

I'm still keep thinking @jacklovell's name of the "Mockamak" is better! :D

CnlPepper avatar Jan 31 '20 21:01 CnlPepper

But the sample size of 1 layman at home suggests Generomak is easier to understand.... ok I'll stop polluting the issue queue now.

CnlPepper avatar Jan 31 '20 21:01 CnlPepper

As mentioned by @vsnever and @jacklovell in #268, we should decide where we will keep the data and codes connected to Generomak (out of topic, I also like Mockamak or Mockupmak more, how did I miss this?).

One proposed solution is to create cherab/generomak folder where all the importables and data would be stored. Already proposed structures here and here.

I like the idea of having it separately, it gives a clearer way of structuring the generomak contents and expansion.

Mateasek avatar Feb 16 '21 15:02 Mateasek

I would prefer cherab.generomak over cherab.tools.generomak. I think it is important that the internal structure of cherab.generomak can be used as an example for creating Cherab modules for real machines.

vsnever avatar Feb 16 '21 16:02 vsnever