Marcin Ignac

Results 285 comments of Marcin Ignac

Related [Pipeline properties of material require new material from scratch](https://github.com/pex-gl/pex-renderer/issues/44)

It would make it more clear what's happening as instanced color is multiplied by base color. I call it tint in glsl anyway https://github.com/pex-gl/pex-renderer/blob/master/glsl/PBR.frag#L1411

currently we have ```javascript renderer.geometry({ positions: [], normals: [], vertexColors: [] offsets: { data: [], divisor: 1 }, colors: { data: [], divisor: 1 } }) ``` ```javascript renderer.geometry({ positions:...

Another reason to use `colors` not `vertexColors` is glTF vertex color attribute is named `COLOR_0` https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#meshes

Added this to 3.0.0 milestone as it's breaking and we change it now or never.. Still undecided on the `tints` name though. Probably better than `instanceColors` though.

@dmnsgn any updates on that? e.g. progress of gltf discussion or maybe we should do research how babylon or three.js are naming things

ThreeJS is actually vertexColors and instanced colors and offsets https://github.com/mrdoob/three.js/blob/master/examples/webgl_buffergeometry_instancing.html#L153 BabylonJS seem not to have instanced color support? https://doc.babylonjs.com/how_to/how_to_use_instances

I would propose that unless we are willing to use `instance*` prefix we should close those issue and wait for GLTF to clarify. ```javascript geometry.set({ positions: [], normals: [], vertexColors:...

One thing about `instance*` prefix is that it would make it clear what's supported and what's instanced. We could then drop the requirement for `{ divisor: 1 }` as it...

@dmnsgn @simonharrisco if we go ahead with this: ```javascript geometry.set({ positions: [], normals: [], colors: [], instanceOffsets: [], instanceScales: [], instanceRotations: [], instanceColors: [] }) ``` Then is it still...