Marcin Ignac

Results 285 comments of Marcin Ignac

Yes it checks for invalid enums and parameters of function calls. So you can catch error when it happens not at some point in the future or end of frame.

Why do we not support in in gltf in Safari? From https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmap ![Screenshot 2022-06-08 at 12 04 38](https://user-images.githubusercontent.com/171001/172601362-02ddb3e5-c573-4299-a3a8-54c9054e886a.jpg)

Btw FF gives better error in WebGL1 `WebGLRenderingContext.texImage2D: Argument 9 does not implement interface ArrayBufferViewOrNull.`

Possible fix here https://stackoverflow.com/questions/42073596/webglrenderingcontext-teximage2d-does-not-implement-interface-arraybuffervieworn Hmm if i do this in WebGL1 then it works.. does it mean ImageBitmap is considered HTMLElement in WebGL1 and ArrayBuffer view compatible in WebGL2 only?...

Oh that's so confusing because `EXT_color_buffer_float` seems to be handling both 32F and 16F. Fine.

Let's not use Chrome only features in libs

To be precise i mean multiscatter ggx preventing loosing energy from IBL for metallic materials This is tested using Furnace Test with pure white environment map. As you can see...

Examples here https://doc.babylonjs.com/how_to/physically_based_rendering_master#energy-conservation

Original (?) source of discussion https://eheitzresearch.wordpress.com/240-2/ ![multiplescatteringsmith_res1](https://user-images.githubusercontent.com/171001/62543284-871bfc80-b855-11e9-8ae4-8fe4a048b352.png) Excellent explanation of math https://patapom.com/blog/BRDF/MSBRDFEnergyCompensation/ ![Screenshot 2019-08-06 at 14 05 57](https://user-images.githubusercontent.com/171001/62543240-681d6a80-b855-11e9-8a47-d774e7894a21.jpg) ThreeJS PR https://github.com/mrdoob/three.js/pull/15644 ![51778960-5d6d6600-20b9-11e9-9311-ca8b060dc8fe](https://user-images.githubusercontent.com/171001/62543305-956a1880-b855-11e9-89f4-8422aeec4181.png) Filament implementation https://google.github.io/filament/Filament.md.html#materialsystem/improvingthebrdfs/energylossinspecularreflectance ![Screenshot 2019-08-06 at 14 22...