Vojtěch Michal
Vojtěch Michal
Hi all, I’ve been thinking about contributing to the STL recently, and this issue looks like a small, self-contained change I could start with. Much of my early C++ education...
Thank you for suggestions, I have put the patch together and opened a PR. I have a few comments regarding the resolution of this issue, but I will list them...
Hi, just for completeness, this PR is not set to close the corresponding issue #5886 on merge. I'd say it would help the PR process to indicate that properly (if...
Hi, I would like to work on this issue; it seems reasonably small. Unfortunately, I can't access the link https://wg21.link/P3612R1 you have provided. I can access only R0 of the...
Also, regarding tests, should I create an entirely new test in a new directory, or do you prefer to augment (or reuse) existing tests? For example, `std/tests/Dev10_816787_swap_vector_bool_elements` seems like a...
@microsoft-github-policy-service agree
Sections 4.1, most of 4.7 and 4.8 of the paper prescribe changes this STL already has (some `#include`s and noexcept/conditionally noexcept functions), so there was nothing to do. Section 4.9...
There are two failing tests (copied from CI): ``` std :: tests/Dev11_1074023_constexpr:37 (3864 of 7663) libc++ :: std/language.support/support.initlist/support.initlist.range/begin_end.pass.cpp ``` `Dev11_1074023_constexpr` fails on line 56 ``` STATIC_ASSERT(begin(il) == end(il)); ``` The...
I wanted to look into it, but it seems like the only related comment is here: https://github.com/microsoft/STL/blob/5459853bf78ceef1137d845bfeca98f658659691/stl/inc/xutility#L626-L629 Opening a PR just to remove `// Per LWG-3454` is bananas... Am I...
> Looks like that this PR should also fix #4144 and #5569. Thanks for the suggestion, I will check them thoroughly (on the first glance they indeed seem fixed) soon....