Vojtěch Michal

Results 21 comments of Vojtěch Michal

I took examples from both issues and added them as tests. Indeed, both should also be resolved by this PR.

Notes and questions for review: The behavior of most overloads stays identical, as they are all implemented in terms of other functions from the `wait_{for, until}` family, just with relative...

I have incorporated @frederick-vs-ja 's suggestions. However, regarding the failing tests, I am baffled a little. I can't _reliably_ reproduce the failure - I reproduced it twice using `stl-lit`, but...

> Are there timing assumptions in your tests? Whenever exercising timeout-related code, we need to be very careful to write tests such that they always succeed, regardless of how quickly...

There is a `constexpr const reference& operator=(bool x) const noexcept` in `std::vector::reference` since P2321 but it was wrapped by `_HAS_CXX23`. I have removed the conditional compilation, as I've understood that...

> By the way, please edit your original PR description to say "Resolves #nnnn". Only PR descriptions can set up the auto-resolve links with the magic phrases. In ordinary comments,...

It is now failing because of tests of the static `vector::swap(reference, reference)`. Any advise on prefered resolution method? Whether to silence the deprecation warning for the test.cpp or to remove...

> Oh, and please validate your changes with a local test run for any updated/affected tests, before pushing changes. This is both faster for you to iterate with, and avoids...

Hi, I am working on this. The change is minimal and obvious; however, I am having a bit of trouble with the test suite. I am extending `tests\std\tests\GH_000685_condition_variable_any`, checking all...