STL Enable bidirectional optimization for non-common ranges in `std::ranges::partition`

See #5886.

Nov 20 '25 13:11 mirion-dev

I think it's better to remove the issue number from the PR title. Things will be confusing if it goes into squashed commit message.

Nov 20 '25 14:11 frederick-vs-ja

Hi, just for completeness, this PR is not set to close the corresponding issue #5886 on merge. I'd say it would help the PR process to indicate that properly (if you are certain the PR actually solves the issue, ofc. It looks good to me).

Nov 23 '25 19:11 vmichal

Hi, just for completeness, this PR is not set to close the corresponding issue #5886 on merge. I'd say it would help the PR process to indicate that properly (if you are certain the PR actually solves the issue, ofc. It looks good to me).

Hi, thanks for the reminder! I've updated the description. I actually wasn't aware of the auto-close feature.

Nov 24 '25 00:11 mirion-dev

Thanks! :heart_eyes_cat: I verified with a static_assert that we have existing test coverage for bidi-but-not-common ranges in libcxx std/algorithms/alg.modifying.operations/alg.partitions/ranges_partition.pass.cpp and std P0896R4_ranges_alg_partition.

Nov 25 '25 16:11 StephanTLavavej

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Nov 25 '25 18:11 StephanTLavavej

Thanks for optimizing this ranges algorithm, and congratulations on your first microsoft/STL commit! :tada: :smile_cat: :rocket:

Nov 27 '25 21:11 StephanTLavavej