Valentin Balaschenko
Valentin Balaschenko
Untrusted Validator Squelching - Extends squelching to limit untrusted validator message propagation
Looks great to me! The only big question I raised is about clearing disconnected validators public keys. Once this question is resolved, I'm happy to approve this PR
Should be enabled after Lending Protocol is done.
Merged into hot fix branch
https://github.com/XRPLF/rippled/pull/5371
Hello. To double check: is your intention to run the node in a Historical mode? When using the node in validation mode, it should take ~15 when starting from scratch...
> So the idea is you're just commenting out the `#include` to test levelization, but not necessarily removing it permanently? Because if you're removing it, you should just delete it....
# Analysis of Reference Count Ranges for Intrusive Smart Pointers ## Background Following the conversation in the original PR ([Intrusive shamap inner (SHAMapTreeNode memory reduction) by seelabs · Pull Request...
> The theoretical maximal value for string references is calculated to be 210. Experimental evidence also from the readme detects a value above the theoretical maximum: 387. I ran a...
See the original PR and review comments here: https://github.com/XRPLF/rippled/pull/4815
> Should these flags be defined in the top level `CMakeLists.txt` instead of `cmake/RippledCompiler.cmake`? Eventually, I'd like to move all this to `CMakePresets.json` anyway. > > `-Wno-subobject-linkage` produces > >...