Valentin Balaschenko
Valentin Balaschenko
Some commits are not signed. You need to rebase and sign every commit.
Most recent changes are breaking the unit-tests @gregtatcam
There there are several Transactors that check have checks for `featureMPTokensV1`. Should those Transactors also check for `featureMPTokensV2`?
In AssetCache.cpp three XRPL_ASSERTs need to be updated from ``` 82,30: "ripple::RippleLineCache::getRippleLines : maximum lines"); 104,22: "ripple::RippleLineCache::getRippleLines : null lines"); 117,18: "ripple::RippleLineCache::getRippleLines : null or nonempty lines"); ``` to ```...
[nit]: Once the unit-testing is sorted this comment in the PR description need to updated: ``` Significant number of unit-tests must be added to test all aspects of MPT interactions...
@sublimator Is this issue still relevant ? Was it addressed?
@mDuo13 Can you confirm please if this is still useful / relevant?
@mDuo13 Can you please confirm if this is still relevant?
@intelliot Can you confirm that this issue is still relevant?
If Reporting Mode is obsolete, is this ticket still relevant @mDuo13 ?