Vivek Kale comments

Results 102 comments of


                                            Vivek Kale

Addition of Kokkos sampler

LGTM with the most recent changes.

Addition of Kokkos sampler

> PR needs to target the develop branch @vsurjadidjaja Following up here on @dalg24, do you think you can create a new PR, i.e., separate PR that is a copy...

understanding MemoryUsage

Updated wiki with documentation. Thanks for the question.

Update simple kernel timer to write output to text file

I believe PR #235 helps to address this Github Issue.

Update simple kernel timer to write output to text file

@jeffmiles63 I am closing this as this #235 should now address this. Please let me know in case there are other questions here.

Nvprof region limiter

@jeffmiles63 I want to just check this PR with you and see if you wanted to add or do more with it in, say, the next month or so. This...

Use Kokkos::Tools::Experimental::device_id for all Profiling events

@ajpowel cc. @masterleinad Great, thanks for that. On Jul 31, 2023, at 3:12 PM, ajpowelsnl ***@***.***> wrote: Hi @vlkale, it looks like @masterleinad has done some work on this issue....

Using tools induces undesirable fences in certain cases

The fix is discussed and tested, and this is part of kokkos-tools develop branch now.

Remove KOKKOSTOOLS_LIBRARY_MODE

Looks OK to me especially if KOKKOSTOOLS_LIBRARY_MODE is not doing anything anyway given what `kp_add_library` expects. Note that the sampler and filter are the only two utilities in Kokkos Tools,...

Sampler's begin for callee's null check before fence (less overhead in corner case)

> You'll have to fix the indentation. Thanks! Applying clang-format today.