kokkos-tools icon indicating copy to clipboard operation
kokkos-tools copied to clipboard

Addition of Kokkos sampler

Open vsurjadidjaja opened this issue 2 years ago • 2 comments

Proposing the addition of the LDMS-Kokkos sampler to the Kokkos-tools repo. This sampler is responsible for down regulating the amount of kernel function names sent to the LDMS-Kokkos connector. LDMS (Lightweight Distributed Monitoring System, https://github.com/ovis-hpc/ovis) provides a low overhead monitoring, transport and storage capability. LDMS uses Kokkos function calls to monitor application activity in real time. This sampler down regulates the number of kernel function calls from the application and send them over to LDMS's Kokkos connector. Makefile also available.

This is a resubmit of PR#137.

vsurjadidjaja avatar May 10 '22 18:05 vsurjadidjaja

uhm isn't this all in the wrong places? i..e the sampler inside the filter, another Makefile fin some ldms-sampler directory?

crtrott avatar May 13 '22 20:05 crtrott

@crtrott Apologies for placing this in a sub directory. I have fixed the issue.

vsurjadidjaja avatar Jun 06 '22 20:06 vsurjadidjaja

LGTM with the most recent changes.

vlkale avatar Feb 01 '23 13:02 vlkale

PR needs to target the develop branch

@vsurjadidjaja

Following up here on @dalg24, do you think you can create a new PR, i.e., separate PR that is a copy of this one, which is against develop branch of Kokkos Tools github repository? The Kokkos team recently - in the last few months - changed our developer contribution process for Kokkos Tools such that contributions are no longer made to the master branch (which was the user-facing branch) and we will only provide the user-facing Kokkos Tools a release. On a related note: I am working to get Kokkos Tools released soon. Having your changes in the latest release will be useful so that it can be used by more applications.

Thanks!

vlkale avatar Mar 09 '23 22:03 vlkale

Copied to PR#169 and built against the develop branch.

vsurjadidjaja avatar Mar 21 '23 18:03 vsurjadidjaja