Vivek Kale

Results 101 comments of Vivek Kale

> > The safest way to fix this is to just match the exact and full string I want to match in one matcher. > > You would not even...

> > > > Your test is really weak. It will pass if the sampler does nothing and just always forward to the underlying tool. > > > > >...

> > > I have a broader question here: What role should tests for Kokkos Tools play? > > Ensure that the tools behave as they are supposed to and...

@dalg24 @masterleinad I think I have answered most of your questions. The CI tests are now passing with the changes. Please let me know if there is still anything unresolved....

@jrmadsen I have updated the description of this Github Issue.

In looking again at the Draft PR and prototype for overlays by David Poliakoff in #117, the ideas and code I am seeing seems to address the problem put forth...

@rppawlo Is this resolved for you given the comment from @masterleinad above?

> > @rppawlo Is this resolved for you given the comment from @masterleinad above? > > > > No, it's not. The information we are forwarding doesn't include the number...

@crtrott I discussed this with Carl. Carl is using this for his work. This would also well-serve Kokkos Tools because it is a basis to have a generalized ToolState struct...

> @vlkale I changed the name of the callback to mark_kernel_static_info and defined a 512-byte struct, so while this currently only tracks functor size, it could be extended to include...