Vivek Kale

Results 102 comments of Vivek Kale

I have put the Wiki page for ScoreP here: https://github.com/kokkos/kokkos-tools/wiki/ScoreP The page contains a starter description of the tool connector and links to pertinent documentation.\ @wrwilliams Are you able to...

@wrwilliams Yes, as @masterleinad suggested, you can open a PR to the wiki page for ScoreP here: https://github.com/kokkos/kokkos-tools/wiki/ScoreP It will be reviewed and merged once it's there. It would be...

> Actually I cannot presently open a PR, as the wiki repo is not accessible to non-collaborators. > > > > https://github.com/kokkos/kokkos-tools.wiki.git leads to the GitHub 404 page for me,...

@wrwilliams To follow-up, I don't have an easy solution for the moment on the wiki. However, you do have the ability to create a PR to the Kokkos Tools repo....

> What prevents you to create a docs/ directory and document in a markdown file? This is a good idea, and it could complement or replace having a README.md file...

@masterleinad When you were saying to test tool-invoked fencing function pointer is NULL, I wasn't sure if you were referring to just a test that the sampler finished successfully, or...

> Avoid duplicating code between tests OK. I will check and refactor. > Your test is really weak. It will pass if the sampler does nothing and just always forward...

> > Avoid duplicating code between tests > > OK. I will check and refactor. > > > Your test is really weak. It will pass if the sampler does...

> Please clearly summarize all the changes you are making in this pull request. See the revision above.

@dalg24 @masterleinad I believe this should address your comments now. The CI tests are passing (and those CI tests run the tests for the sampler). I also included the null...