Vladik Romanovsky

Results 188 comments of Vladik Romanovsky

> > Are we certain that this approach will work with cgroups v2? I remember that there were some implications with some files being visible but not accessible. > >...

> > > Passing an FD instead of path is always possible, it however requires some intervention of virt-handler that which this version isn't necessary. It is everything handed by...

In general, the `ShadowNode` approach with the variation that @Barakmor1 suggested, would be my preference. My main fear is that Validating Admission Policy for virt-handler will make a debugging, when...

Looks like no one else is objecting besides me, so let's proceed with this. /approve

> Approvers, where do we stand? > > /lgtm Aren't you an approver @fabiand ?

@lyarwood Thanks! I think it makes a lot of sense to do it now.

/approve Thanks, very nice! And apologies for the delay.

@atanasdinov It's a nice proposal. My only concern is how it can be maintained and supported as part of core KubeVirt? I doubt we have any expertise around Helm... Could...

> /remove-lifecycle stale @vladikr Did the above comments allay your concerns? My preference would be to keep this chart outside of the kubevirt/kubevirt repo but in the kubevirt org.