Vladik Romanovsky

Results 188 comments of Vladik Romanovsky

> /hold > > Let's start with a design proposal before iterating on live migration policy improvements. @stu-gott are you suggesting to write in that proposal more than is written...

> Thank you very much @vladikr, this looks great. > > Except for the two remaining points above [[1](https://github.com/kubevirt/kubevirt/pull/11833#discussion_r1780768489)][[2](https://github.com/kubevirt/kubevirt/pull/11833#discussion_r1780786608)], a thought that have crossed my mind is that today if...

@LunarInterface Thanks for raising this issue. Qemu enables vmport by default. Since there wasn't much community interest in controlling this parameter, KubeVirt simply didn't set anything. I see now that...

> Great to see you as an adopter! +1 Great to see this PR!

@talcoh2x could you please sign your commits with `--signoff` ?

@talcoh2x all commits should have the `Signed-off-by: Tal Cohen ` Perhaps it's just better to squash all the existing commits? or add the signoff to all other commits, please.

Thanks @talcoh2x /approve