Vladik Romanovsky
Vladik Romanovsky
Thank @ebblake ! Great to see this PR!
@zhangchi6414 the messaging can indeed be improved in virt-handler. The message in your report speaks about `PCI_RESOURCE_` while you are assigning an `MDEV` - a mediated device (NOT PCI) so...
Sorry, I didn't get to it earlier. This definitely makes sense, thanks! /approve
> I revert it to the previous version and made the ClaimName in PersistentVolumeClaimInfo optional. > > UPDATE: new fields need to be optional because of the upgrades. During upgrading,...
It took me some time to remember the details and wrap my head around this PR. I need some more time for another round.
> > > > @akalenyu ping > > > > > > > > > This is a big change so I am not that keen on going for this...
> One current problem with this change is that virt-launcher now signals the containerdisk process to terminate in order to have a graceful shutdown and the pod to be set...
Are we certain that this approach will work with cgroups v2? I remember that there were some implications with some files being visible but not accessible. Also, are we sure...
> > Are we certain that this approach will work with cgroups v2? I remember that there were some implications with some files being visible but not accessible. > >...