Martijn Visser

composing connected ODESystems

5

Hi, I was wondering, is it possible to connect the ODESystem created by this package with other ODESystems, and if so, how? I'd like to model a wave that on...

stop using Base.convert

7

Following discussion in #49. I tried implementing Base.convert as suggested by the [GeoInterface docs](https://juliageo.org/GeoInterface.jl/stable/guides/developer/#Conversion) for GeometryBasics, testing with GeoJSON geometries. The first method is needed to send the 2-arg convert...

Enforce coordinate eltype

5

Do we currently expect anything from the coordinate eltype? Was SF always Float64? What do we do, `

check error logging on multi threading

2

There was an issue with (wrong) negative f inputs that understandably caused a DomainError in the `log` function here: https://github.com/Deltares/Wflow.jl/blob/af04ae4b8c9d2b65624a466a86f3b834b404be37/src/horizontal_process.jl#L85 However when running this code multithreaded, this error was not...

OpenDA coupling

1

~~This will likely need BMI 2.0 support in OpenDA first.~~ We will probably do this using the black box model approach, using the `wflow_cli`.

Forcing data is loaded in place and we don't do extra checks to see if there are missing values present. That leads to errors further on, usually with a `InexactError:...

probably at Model level

Right now for nested keys, it will not display what section a key cannot be found in. It would be nice to get error messages like: ``` KeyError : key...