Martijn Visser

Results 193 issues of Martijn Visser

This is not beautiful: ![image](https://github.com/Deltares/Ribasim/assets/4471859/ce4c83d8-e7f3-4688-8bb7-1b9408e2a43c) For the QGIS plugin we use our logo, stored in `ribasim_qgis\icon.png`. It would be good to also add this to our executables. ![icon](https://github.com/Deltares/Ribasim/assets/4471859/83859698-e84c-4abf-ba93-7d6a200735cc)

enhancement

Not sure if this is already done elsewhere, but it would be nice to not have to do this step locally. Brought up [here](https://github.com/Deltares/Ribasim/issues/499#issuecomment-1682300239) - [ ] update TeamCity configuration...

enhancement
CI/CD

**What** Currently duplicate records are not validated, leading to hard to understand errors later on. A recent example is https://github.com/Deltares/Ribasim-NL/issues/54#issuecomment-1915030990. **Why** To give modelers better errors and prevent malformed input...

validation

We now have a formal model description: https://deltares.github.io/Ribasim/core/equations.html#formal-model-description We still need a better informal general description. The closest we have is on the main page: https://deltares.github.io/Ribasim/, but that needs an...

documentation

Currently only Basin and TabulatedRatingCurve support it. What is needed: - [ ] create the schemas in validation.jl - [ ] add the schemas to the usage docs - [...

physics
improvement

If you have a small Basin with e.g. a large infiltration, the model is not very stable. We need to build a test model for this case to make sure...

performance
core

https://deltares.github.io/Ribasim/python/reference/ Could be due to changes in https://github.com/machow/quartodoc Possibly related to #219 Edit: I think it is working fine, but we just don't have many docstrings anymore. And currently methods...

documentation

Currently we only use the Quarto HTML output which we host online. For offline use it would be good to build and include the PDF output of our documentation. https://quarto.org/docs/output-formats/pdf-basics.html...

documentation
enhancement
CI/CD

#1082 put the results description in a separate section. From that it became clear that the `subgrid_levels.arrow` description is missing.

documentation
coupling

**What** We support running a physical simulation without using allocation. But not the other way around. **Why** For planning studies having a physical simulation is not always needed. At the...

allocation
usage