Wflow.jl icon indicating copy to clipboard operation
Wflow.jl copied to clipboard

Published 20 hours ago • verified publisher icon Deltares

check error logging on multi threading

Open visr opened this issue 4 years ago • 2 comments

There was an issue with (wrong) negative f inputs that understandably caused a DomainError in the log function here: https://github.com/Deltares/Wflow.jl/blob/af04ae4b8c9d2b65624a466a86f3b834b404be37/src/horizontal_process.jl#L85

However when running this code multithreaded, this error was not thrown. We should check why that is. #138 will help here as well.

See also https://github.com/JuliaLogging/TerminalLoggers.jl/pull/41

visr avatar Jun 08 '21 08:06 visr

In hydromt, we recently fixed the calculation of the f parameter, which should now not produce negative values anymore (constrain M function was previously not applied to f).

laurenebouaziz avatar Jun 08 '21 10:06 laurenebouaziz

Yes, thanks, Willem showed me that you fixed it. Still created this issue to understand the interaction with error handling and multithreading a bit better.

visr avatar Jun 08 '21 10:06 visr