Martijn Visser

Results 604 comments of Martijn Visser

For now I would suggest to aggregate daily output to monthly values during post-processing. Supporting this should be possible but is not trivial since as you say the saveat periods...

Yeah I made https://github.com/Deltares/Ribasim/pull/2709 for the docs.

There is this previous thread on NCDatasets.jl: https://github.com/Alexander-Barth/NCDatasets.jl/issues/57 Regarding DiskArrays support for NCDatasets, that has been a long time coming but https://github.com/Alexander-Barth/NCDatasets.jl/issues/79 seems to be actively worked on in https://github.com/Alexander-Barth/NCDatasets.jl/pull/205....

While working on #1835 I saw something strange. The backwater model tests started failing with finite diff. The actual heads were just over a meter higher on the upstream end,...

Presumably fixed by #2134.

Hmm it is hard to say, perhaps the first dataset was not written by GDAL and missing some metadata. I see it shows LIBERTIFF/GeoTIFF as the driver that is used....

No this isn't possible currently. Though perhaps it would also be fine to split the UserDemand into two, one for the wet season and one for the dry season, and...

In https://github.com/Deltares/Ribasim/pull/2572/commits/f7d69720d6bfc57c2d6099d37c6937d566aebc8f I chickened out and left only the `@threads` in `set_current_basin_properties!`, the one that is responsible for most of the speedup. In the Linux regression tests there was this...

Thanks, yes that is also good to compare. I guess that has similarities to the [ChunkSplitters.jl](https://github.com/JuliaFolds2/ChunkSplitters.jl) approach, but also uses [Polyester.jl](https://github.com/JuliaSIMD/Polyester.jl/) for many threads? I haven't used ChunkSplitters before, but...