Martijn Visser

Results 601 comments of Martijn Visser

Would be great to have this merged.

Ok I've addressed that now. Running this code locally still results in `get_general_pkgs()` being empty since my depot isn't in my homedir. I guess that means this doesn't fix #294,...

Ah right, reopening for that. Unless this becomes fixed altogether with #1897.

This was improved by #1912 but the core problem is still there so re-opening. For example, this is a graph of the balance error of the basic testmodel `Basin #3`...

Running with `reltol = 0` as suggested in https://github.com/Deltares/Ribasim/issues/1897#issuecomment-2412985333 for basic_transient 100 years gets almost the same balance error as above but takes twice as long to compute.

Nevermind, whilst working on an issue I guess I bricked a model database. Removing `generated_testmodels\*` fixed this. Keeping this open to discuss if we want to trigger this code on...

This may also be related to the water balance error the iMOD Coupler team sees when running the backwater model with groundwater exchange through BMI. #1896 may already help with...

Here on the Amstel the total flow rate on the bottom half is about the same as the top half. Both have several links on top of one another. The...

Oh nice, yeah then we can try option 1 first and consider option 2 if that isn't good enough. I was thinking to first implement in Python in `model.to_xugrid`, and...

We can probably keep using the `nctype2jltyp` dict we have now internally, but whenever we use it we must account for the possibility that the key is not present, e.g....