Martijn Visser
Martijn Visser
Yeah since https://github.com/Deltares/Ribasim/pull/2112 Python validates this on add. It doesn't seem optimal to validate on input and output side because the add API is regularly bypassed.
Wow I'm surprised, but this actually leads to significantly worse performance. It looks like with the lower power precision the kinematic wave doesn't convergence well. The epsilon of 1e-12 may...
Closing this since it won't get merged like this. We should IMO still see if we can start using FastPower.jl, but the convergence criteria should be set differently for it...