Vishwesh Bankwar

Results 117 comments of Vishwesh Bankwar

@specialforest - Yes. However, this has changed recently due to https://github.com/open-telemetry/opentelemetry-dotnet/security/advisories/GHSA-vh2m-22xx-q94f. All versions of `OpenTelemetry.Instrumentation.Http` lower than 1.8.1 have been marked deprecated. As of now, we do not have an...

@julealgon - Instrumentation library simply gets the RoutePattern set by the framework. https://github.com/open-telemetry/opentelemetry-dotnet/blob/42ecd73bd0956ae41e67894b93d1e3a89a4bbba8/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs#L240-L245 @JamesNK - Do you know if this is intentional? See https://github.com/open-telemetry/opentelemetry-dotnet/discussions/5391 for more details

@julealgon I could not find anything specific to `/` part in the specification. It says [The matched route, that is, the path template in the format used by the respective...

@Kielek - For `Instrumentation.AspNetCore`, `Instrumentation.Http`, we should wait for https://github.com/dotnet/aspnetcore/issues/52439 and https://github.com/dotnet/runtime/issues/93019 to avoid migration issues for users moving to `.NET9.0` from lower versions. `OTEL_INSTRUMENTATION_HTTP_CLIENT_CAPTURE_RESPONSE_HEADERS` and `OTEL_INSTRUMENTATION_HTTP_SERVER_CAPTURE_REQUEST_HEADERS` - Are these...

This is now available with https://www.nuget.org/packages/OpenTelemetry.Exporter.Geneva/1.8.0 as an experimental feature on Windows environment. See [instructions](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Exporter.Geneva#:~:text=Set%20PrivatePreviewEnableOtlpProtobufEncoding%3Dtrue%20to%20opt%2Din%20to%20the%20experimental%20feature%20for%20changing%20the%20underlying%20serialization%20format%20to%20binary%20protobuf%20following%20the%20schema%20defined%20in%20OTLP%20specification.) to onboard.

@JamesNK - This is not a bug in `OpenTelemetry.Instrumentation.Http` as it never emitted `peer.service` before. Looks like this is due to how Otlp exporter handles certain tags and has some...

Thanks everyone for the feedback - The feature is requested for .NET9.0. Please track https://github.com/dotnet/aspnetcore/issues/50654 for updates.

Have you considered using `AlwaysOnSampler()`? --> This will not prevent creation of child activities. The root one can still be filtered out using `Filter` delegate.

@ImoutoChan, @jerviscui - Check out https://learn.microsoft.com/en-us/aspnet/core/log-mon/metrics/metrics?view=aspnetcore-8.0#enrich-the-aspnet-core-request-metric

Related: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/issues/2191 @kaspertygesen Thanks for your interest in this. We are currently working on multiple changes on the instrumentation libraries. We have not evaluated this particular issue in detail. Once...