Vishwesh Bankwar

Results 65 comments of Vishwesh Bankwar

@cijothomas @alanwest - let me know if I missed something or need to add more details.

@cijothomas @alanwest - one of the ways we can achieve this https://github.com/open-telemetry/opentelemetry-dotnet/pull/3519 open to comments / other ideas.

@CodeBlanch - Currently, we attach ActivitySource to the activity in instrumentation library. The [name and version](https://github.com/open-telemetry/opentelemetry-dotnet/blob/d93606ea71d0d124592b3fc60f0388b5701591de/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs#L38-L41) on ActivitySource matches the name and version of instrumentation library as per [spec](https://github.com/open-telemetry/opentelemetry-specification/blob/70fecd2dcba505b3ac3a7cb1851f947047743d24/specification/trace/api.md#get-a-tracer). However,...

@Tusharknath1 - I am not able to repro this on my end. Could you please share your repro app? `Create a self-contained project using the template of your choice, apply...

@sunildatla - Your expectation is correct. However, the server side needs to use that injected `traceparent` to start new Activity. That is missing [here](https://github.com/open-telemetry/opentelemetry-dotnet/blob/11c804ac6825b9fe39ae1ae73af27434e1a891e1/examples/Console/InstrumentationWithActivitySource.cs#L68-L70). That is the reason you do...

Just looked at it again - Example is working as intended. @sunildatla Since you modified the example by adding `AddHttpClientInstrumentation` you would also need to update the Server side as...

@smbecker - Thanks for the PR - Could you please clarify the issue? > This PR fixes an issue when using the OpenTelemetry Hosting Extensions (i.e. AddOpenTelemetryMetrics) where metrics are...

> @smbecker - Thanks for the PR - Could you please clarify the issue? > > > This PR fixes an issue when using the OpenTelemetry Hosting Extensions (i.e. AddOpenTelemetryMetrics)...