Vishwesh Bankwar

Results 117 comments of Vishwesh Bankwar

Moving the discussion here https://github.com/open-telemetry/opentelemetry-dotnet/issues/4437#issuecomment-1690643969 @eerhardt @noahfalk @JamesNK @cijothomas

# Update ## Background The request from the .NET team is to incorporate specific metrics as default features in the instrumentation libraries provided by this repository. This change will facilitate...

I think we should go with option-1. It brings considerable value to .NET users by adopting OOTB metrics. The additional metrics are designed specifically for .NET applications to provide deeper...

@dpk83 : Sharing an update here based on my investigation Regarding the issue about custom Middleware being more efficient than instrumentation library, I think this is not accurate. The sample...

https://github.com/dotnet/runtime/issues/86667 Based on discussions on this, I think we should not pursue this. A note in our Readme should be good enough that this scenario is not supported.

@open-telemetry/dotnet-approvers @open-telemetry/dotnet-maintainers FYI

> could you clarify what is the plan for http client metric tags enrichment in Otel targeting .NET 8? Is it something that is going to be available in the...

> > If you are in .NET 8.0 or newer, the .NET's built-in mechanism would help with Enrich, so you won't miss anything. > > If you pre .NET 8.0...

> My assumption was that this code: > > ```cs > services.AddOpenTelemetry().WithMetrics(metrics => metrics.AddHttpClientInstrumentation()); > ``` > > Would enable instrument `http.client.request.duration` internally, but I can't find this code. >...

The current plan is to bring back in the next non-stable release (Post GA).