Vishwesh Bankwar
Vishwesh Bankwar
Related: https://github.com/dotnet/aspnetcore/issues/51620
@lachmatt - Could you please clarify where these requirements are coming from? * Only invalid baggage items are rejected during injection * All of the baggage items are rejected during...
> > @lachmatt - Could you please clarify where these requirements are coming from? > > > > * Only invalid baggage items are rejected during injection > > *...
> Some thoughts for anyone taking a look at this... > > * We don't necessarily have to obsolete _anything_. I put them in initially to see the fallout. I...
> @vishweshbankwar > > > @CodeBlanch - I think we should not mark things obsolete rn. > > Based on what thinking/reasons? Please elaborate a bit 😄 * Based on...
@Barsonax - Do you have a repro?
@Barsonax - Just adding some clarification here: HttpClientInstrumentation does not propagate the baggage that is set via `Activity.Current?.SetBaggage("foobar2", "fus43gf3g3")` You would need to Use [Baggage API](https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Api#baggage-api) for that. https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Api#baggage-api
@jdt - Your proposed fix looks reasonable to me. [Spec](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#:~:text=HTTP%20request%20may,error.type%20attribute) also suggests setting the status to error. Not sure what the `error.type` attribute would be in this case. Adding @antonfirsov...
> > Not sure what the `error.type` attribute would be in this case > > In SocketsHttpHandler/HttpClientHandler it is the namespace-qualified exception name in this case, ie. `System.Threading.Tasks.TaskCanceledException` or `System.OperationCanceledException`....
@jdt - `OperationCanceledException` for metric also sounds good to me. Eventually the tracing and metric should get consistent when https://github.com/dotnet/runtime/issues/93019 is done in .NET9.0. @antonfirsov - What do you think?