azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Set Statsbeat connection string based on customer's endpoint

Open vishweshbankwar opened this issue 3 years ago • 1 comments

vishweshbankwar avatar Aug 29 '22 18:08 vishweshbankwar

/check-enforcer override

vishweshbankwar avatar Nov 10 '22 21:11 vishweshbankwar

Hi @vishweshbankwar. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

ghost avatar Jan 13 '23 10:01 ghost

API change check

API changes are not detected in this pull request.

azure-sdk avatar Jan 19 '23 18:01 azure-sdk 

   internal const string StatsBeat_ConnectionString_NonEU = "<Non-EU-ConnectionString>";
   internal const string StatsBeat_ConnectionString_EU = "EU-ConnectionString";

one with angle bracket and one doesn't.. i wonder how you initialize its value and assume this is just a placeholder.

heyams avatar Jan 24 '23 18:01 heyams 

   internal const string StatsBeat_ConnectionString_NonEU = "<Non-EU-ConnectionString>";
   internal const string StatsBeat_ConnectionString_EU = "EU-ConnectionString";

one with angle bracket and one doesn't.. i wonder how you initialize its value and assume this is just a placeholder.

https://github.com/Azure/azure-sdk-for-net/blob/300ba15f1793c2584bbe43ffd295dc1d5a76cfb6/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/Statsbeat.cs#L163 This is just a placeholder. Will replace the value with actual ones before enabling.

vishweshbankwar avatar Jan 24 '23 18:01 vishweshbankwar