azure-sdk-for-net
azure-sdk-for-net copied to clipboard
Azure
Fix OTEL metrics provider to support IDeferredMeterProviderBuilder
This PR fixes an issue when using the OpenTelemetry Hosting Extensions (i.e. AddOpenTelemetryMetrics) where metrics are not getting published. The metrics exporter is not looking for IDeferredMeterProviderBuilder, so the inner handler was never getting configured with the exporter.
Thank you for your contribution @smbecker! We will review the pull request and get back to you soon.
Please split the PR to address one concern at a time. Thanks!
Done, I'll open a separate PR for adding support for long metric types.
Hi @smbecker. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
@smbecker Are you working on this? @rajkumar-rangaraj / @vishweshbankwar - could you help review/merge this PR?
@smbecker - Thanks for the PR - Could you please clarify the issue?
This PR fixes an issue when using the OpenTelemetry Hosting Extensions (i.e. AddOpenTelemetryMetrics) where metrics are not getting published.
Do you mean the metrics are not getting exported?
@smbecker - Thanks for the PR - Could you please clarify the issue?
This PR fixes an issue when using the OpenTelemetry Hosting Extensions (i.e. AddOpenTelemetryMetrics) where metrics are not getting published.
Do you mean the metrics are not getting exported?
@smbecker - Could you please follow this for the proposed change?
In case of Azure Monitor, MetricReaderOptions part is not configurable at this moment. We will revisit this once we have more details.
Hi @smbecker. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @smbecker. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @smbecker. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.