Piotr Idzik

Results 122 comments of Piotr Idzik

> can you please tell me if you have any specific requirement in mind. #5223 is a good place to look at. A straightforward implementation with reasonable tests, should be...

Please have a look at #1605. For this update the token is needed.

@GouthamGuna the problem looks like a _leetcode_ puzzle and: https://github.com/TheAlgorithms/Java/blob/2568b96784e50ce517aa223e29302fc10ef3caac/CONTRIBUTING.md?plain=1#L3 In my opinion this simply does not fit to this repository. @BamaCharanChhandogi what is your opinion?

Just a small tip: if you want to modify the last commit, you can use `git commit --amend` and then just push your changes with `--force`. Happy hacktoberfest!

> I don't know how to do format. This is my first pull request. I will try again soon Just run `clang-format`. If you are having problems with that, please...

There are already two implementations: - [`RabinKarp.java`](https://github.com/TheAlgorithms/Java/blob/648572a8c53540d64de52a4692d7c13ff81a4cb9/src/main/java/com/thealgorithms/strings/RabinKarp.java), - [`RabinKarpAlgorithm.java`](https://github.com/TheAlgorithms/Java/blob/648572a8c53540d64de52a4692d7c13ff81a4cb9/src/main/java/com/thealgorithms/searches/RabinKarpAlgorithm.java).

> 👀why there are two implementations then? No idea. > is it allowed? No. EDIT: Since you have a fresh knowledge about Rabin-Karp algorithm feel free to take care of...

@deepu105 could you please approve the workflow? Also please let me know if you would suggest another way solving this (like: removing these fields).

@adimiz1, @michal-sordyl-cloudinary, @colbyfayock: is there anything else what I should do regarding this pull request?

@sozelfist could you take a look? Do you have some reasonable idea how to _refactor_ `stable_matching` into smaller pieces?