[OTHER] Cleanup classes with very strange design

[vil02]

What would you like to share?

There are probably many classes in this repository, which have some strange design - we should update all of them. I think we can start with cleaning up these:

List of the classes needing redesign:

• [ ] AllPathsFromSourceToTarget
• [x] ArrayCombination (#5181 by @yuvashreenarayanan3)
• [x] Combination
• [ ] ColumnarTranspositionCipher
• [x] StringMatchFiniteAutomata (#5222 by @samuelfac)
• [x] LetterCombinationsOfPhoneNumber (#5221 by @samuelfac)

(@siriak, @BamaCharanChhandogi feel free to edit the list above)

Additional information

How to contribute

1. select one class form the list above such that no one else is working on (and is not done yet),
2. write a comment "Hey, I am working on XYZ", where XYZ is your selected class,
3. in your fork, please create a branch like cleanup_XYZ,
4. make your changes and create a pull-request, in which you mention this issue by writing something like "Related to #(this issue number)". Please make sure that you add all necessary tests. If possible, prefer parametrized tests.

Also feel free to suggest a class, which should be added to the list above.

[yuvashreenarayanan3]

Hey, I am working on "ArrayCombination"

[JeysiStrokk]

Hello I´m new here and I would like to help !!!

[vil02]

Hello I´m new here and I would like to help !!!

@JeysiStrokk would you like to work on AllPathsFromSourceToTarget?

[JeysiStrokk]

@vil02 I´ll gladly do it. I´ll try my best !! Thanks a lot !! I´m working on "AllPathsFromSourceToTarget"

[samuelfac]

I´m working on "LetterCombinationsOfPhoneNumber"

[samuelfac]

I´m working on "StringMatchFiniteAutomata"

[samuelfac]

I´m working on "ColumnarTranspositionCipher"

[samuelfac]

@vil02 I´ll gladly do it. I´ll try my best !! Thanks a lot !! I´m working on "AllPathsFromSourceToTarget"

Sorry, I refactored this class without seeing that you had already started. Now I saw in your repository that you only added the comments in the class. That's why I make the pull request.

[samuelfac]

I´m working on "Combination"

[AbeTheAmatuer]

Can I work on "Combination", or "AllPathsFromSourceToTarget"? I know in the comments people were supposed to have worked on this, but they aren't marked as complete, so if they still need work I'd be happy to work on one of them.

[siriak]

@AbeTheAmatuer Sure, feel free to work on them!

[AbeTheAmatuer]

Thanks, I'll work on Combination.

[AbeTheAmatuer]

@siriak I did some cleanup for Combination. It was mostly fine, so I just changed the class name to, "CombinationGenerator", added some comments and changed a variable name for accuracy. I made a PR.

Edit: Ok so changing the class name impacted a bunch of other files so I changed it back and closed my pull request but I fixed the problem and am not sure how to make another one.

[vil02]

@AbeTheAmatuer please have a look at:

• #5223,
• #5224,
• #5225,

by @samuelfac - these PR are in the stage almost to be merged. I am not sure if @samuelfac is planning to continue to work on them - it would be a pity if not..

[AbeTheAmatuer]

@vil02 Ok, do you want me to just review his commits?

[Dileepkumar18311]

Hey, I am working on Combination

[adityasarfare]

Hey, can I help and Contribute in something ?

[adityasarfare]

hey im working on AllPathsFromSourceToTarget

[TarunVishwakarma1]

Hey! I'm working on ColumnarTranspositionCipher

can you please tell me if you have any specific requirement in mind.

[vil02]

can you please tell me if you have any specific requirement in mind.

#5223 is a good place to look at. A straightforward implementation with reasonable tests, should be good enough.

[TarunVishwakarma1]

Sure, I'll start working on this 😊😊

[SAIVARDHAN15]

Hey @TarunVishwakarma1, if you are good I am happy to work on #5223

[TarunVishwakarma1]

Yes, sure go ahead.

[SAIVARDHAN15]

thanks mate! I will be working on "ColumnarTranspositionCipher"

[Anurag127001]

I will be working on "AllPathsFromSourceToTarget"

[SAIVARDHAN15]

hey @Anurag127001! are you working on "AllPathsFromSourceToTarget", if you need any help, I happy to do so.

[lorduke22]

Hello, I am working on "Combination"

[Soumayadip937]

@siriak & @SAIVARDHAN15 is ColumnarTranspositionCipher available? I am new to open source contribution can I start work with this?

[SAIVARDHAN15]

hey there @Soumayadip937, ColumnarTranspositionCipher is alreday closed. You may checkout other open issues.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!