Piotr Idzik

Results 122 comments of Piotr Idzik

> As top(), display() and isEmptyStack() are non modifying methods, you can qualify them with const. Agree - this implementation needs some _cleaning_ - making it _const correct_ and really...

> To remove a few [`clang-tidy`](https://github.com/TheAlgorithms/C-Plus-Plus/actions/runs/3245717513/jobs/5333516869) errors, please change the filename to `stack.hpp`. You might need to update other instances as well. This change indeed _suppressed_ the errors. But as...

> Would you like to work on these files and improve them to our standards? That would fit for another PR, of course. I could do that. However there are...

@StepfenShawn please have a look.

@fr33m0nk you do not have access to it. Who else can edit secrets of this repository?

> Please `don't close`. Or merge.

I think you also want to throw an exception for `y < 0`.

@lulunac27a please fix all of the errors from the CI and please have a look at my [previous comment](https://github.com/TheAlgorithms/Java/pull/5091#pullrequestreview-1969918047).

@Panquesito7, @tjgurwara99, @alexpantyukhin could some of you please add a [`dont-close` or `approved`](https://github.com/TheAlgorithms/C/blob/e5dad3fa8def3726ec850ca66a7f51521f8ad393/.github/workflows/stale.yml#L16C29-L16C50) label?