Java icon indicating copy to clipboard operation
Java copied to clipboard

Implement Sher Lock and Cost Problem.

Open GouthamGuna opened this issue 1 year ago • 3 comments

  • [X] I have read CONTRIBUTING.md.
  • [X] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [X] All functions and variable names follow Java naming conventions.
  • [X] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [X] All new code is formatted with clang-format -i --style=file path/to/your/file.java

GouthamGuna avatar May 21 '24 15:05 GouthamGuna

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 38.74%. Comparing base (2568b96) to head (4d5ca6a).

Files Patch % Lines
...algorithms/dynamicprogramming/SherLockAndCost.java 91.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5169      +/-   ##
============================================
+ Coverage     38.69%   38.74%   +0.05%     
- Complexity     2384     2387       +3     
============================================
  Files           517      518       +1     
  Lines         15405    15417      +12     
  Branches       2959     2960       +1     
============================================
+ Hits           5961     5974      +13     
+ Misses         9158     9157       -1     
  Partials        286      286              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 21 '24 15:05 codecov-commenter

@BamaCharanChhandogi

What are the problems with the code?

GouthamGuna avatar May 21 '24 16:05 GouthamGuna

Hi @yanglbme, @vil02, @BamaCharanChhandogi

Please review the code, and if it meets your approval, proceed to approve it. Otherwise, I would appreciate suggestions for improvement.

GouthamGuna avatar May 25 '24 03:05 GouthamGuna

@GouthamGuna the problem looks like a leetcode puzzle and: https://github.com/TheAlgorithms/Java/blob/2568b96784e50ce517aa223e29302fc10ef3caac/CONTRIBUTING.md?plain=1#L3

In my opinion this simply does not fit to this repository.

@BamaCharanChhandogi what is your opinion?

vil02 avatar May 30 '24 18:05 vil02