Julien Viet comments

Results 921 comments of


Julien Viet

Http2ServerResponse#write(ByteBuf, boolean, Handler<AsyncResult<Void>>) should take empty trailers into consideration

it could also maybe be a bug in encoding an empty trailer frame that is not caught by Netty decoder

Http2ServerResponse#write(ByteBuf, boolean, Handler<AsyncResult<Void>>) should take empty trailers into consideration

Before any change we should check whether this is an actual bug or not. Currently it looks like an issue of the go client. So we should check this with...

Http2ServerResponse#write(ByteBuf, boolean, Handler<AsyncResult<Void>>) should take empty trailers into consideration

let's figure out first if that's a bug or deffect :-) On Tue, Jul 6, 2021 at 12:06 AM markdr-fr ***@***.***> wrote: > > Yes this may be showing up...

ConnectionManager for HttpClient disregards proxyOptions

this is actually expected, one should use always the same proxy with the same host

ConnectionManager for HttpClient disregards proxyOptions

well actually this is debatable, but it was thought that ppl would use the same proxy for the same host

ConnectionManager for HttpClient disregards proxyOptions

i.e I'm not against changing that

Update expired test certificates

where did you see that certificate expired ?

Modify ExecutorServiceFactory API to provide a way to distinguish between pool types

can you elaborate about how the factory will be used ?

Modify ExecutorServiceFactory API to provide a way to distinguish between pool types

Have you looked at `VertxInternal#getWorkerPool()` method ?

SerializableCodec breaks on internal classes

maybe we should rollback the serializable codec or make JsonObject serializable.