Vicente Bolea
Vicente Bolea
I think that this is ready to merge @eisenhauer. This should allow @ax3l to build with adios2 static in windows and we added blosc2 in the windows static build.
> Thanks a lot! I just boarded a plane to Europe, but will try this during the week 👍 Safe trip!
@hr87 Please report this in the https://github.com/spack/spack repository, we contribute to that package there and I also contribute sometimes to the kokkos one.
@suchyta1 thanks for the insights. > But in my opinion, it might make sense not to make the ADIOS2 package explicitly a ROCmPackage The reason of this, is that the...
Right, you can specify variants dependencies. My point is that this syntax might confuse users. I rather have a bit of overextended configuration in the spack package than users opening...
@pnorbert do you mean if we can export the adios2::core target, so projects doing find_package(adios2) can have that target ?
> Actually, it would be simpler if the adios2::cxx11 adios2::cxx11_mpi targets would already add libadios2_core.so to the linker line. This already is the case adios2::core is its private dependency.
> More on that, I see cmake files having if(NOT TARGET adios2::core) and if(NOT TARGET adios2_core) in various places e.g. This was needed for having the tests being buildable in...
> @vicentebolea Could we have adios2::core target available during the adios build too? External codes have to use adios2::core when trying to use adios2::helper functions. During the adios build, adios2_core...
cc @scottwittenburg