Vicente Bolea

Results 156 comments of Vicente Bolea

This looks great, I will have it reviewed ASAP

Last one, please squash the commits into buildable units

@kwryankrattiger Outside of we have succeeded building VTK-m with HIP 4.5 for 1.7.1. For HIP 5.1 the trick was to disable compiler optimizing flags.

@ax3l it appears that we were exporting blosc2 unnecessarily, and when doing out find_dependency defaulted to module as per cmake 3.24, rather than config. Solution seems to be not to...

@ax3l we are release adios 2.10 (final release) very soon. Otherwise I think that those changes are patchable (in 2.10 and 2.9.2)

> @vicentebolea Can I test a branch / RC for ADIOS2 2.10 already? :) Current release_210 should have the fix for the windows static build

@ax3l can you try the 2.10.0-rc1 and when find_package(ADIOS2) add a CONFIG.

Try this branch for fixing the windows build: https://github.com/ornladios/ADIOS2/pull/4093

If you do not need Makefile support for ADIOS2 and only use cmake you can speficy `-DADIOS2_INSTALL_GENERATE_CONFIG=OFF` at configure time to skip this error.